On 7/10/24 03:33, Muhammad Usama Anjum wrote:
Hi Shuah,
Can you take the patch as is or by removing following from this patch:
- if (geteuid() != 0)
+ if (geteuid())
As Aleksa mentioned, geteuid() != 0 is preferred.
On 7/2/24 12:02 PM, Muhammad Usama Anjum wrote:
On 7/1/24 2:14 PM, Aleksa Sarai wrote:
On 2024-07-01, Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> wrote:
Adding more people for review
On 5/23/24 2:46 AM, Muhammad Usama Anjum wrote:
Don't print that 88 sub-tests are going to be executed. But then skip.
The error is printed that executed test was only 1 while 88 should have
run:
Old output:
TAP version 13
1..88
ok 2 # SKIP all tests require euid == 0
# Planned tests != run tests (88 != 1)
# Totals: pass:0 fail:0 xfail:0 xpass:0 skip:1 error:0
New and correct output:
TAP version 13
1..0 # SKIP all tests require euid == 0
I think having total number tell you how many tests are there.
I don't this this is good change.
thanks,
-- Shuah
