On 7/9/24 1:34 PM, Shuah Khan wrote:
On 7/4/24 01:24, John Hubbard wrote:
...>> Muhammad Usama Anjum (1):
selftests: x86: test_FISTTP: use fisttps instead of ambiguous fisttp
Usama and John,
I am seeing checkpatch warnings in this series.
v4-3-7
WARNING: externs should be avoided in .c files
#210: FILE: tools/testing/selftests/x86/fsgsbase_restore.c:46:
+unsigned int dereference_seg_base(void);
ARNING: Consecutive strings are generally better as a single string
#156: FILE: tools/testing/selftests/x86/test_FISTTP.c:28:
+ " fisttps res16""\n"
WARNING: Consecutive strings are generally better as a single string
#165: FILE: tools/testing/selftests/x86/test_FISTTP.c:48:
+ " fisttps res16""\n"
WARNING: Consecutive strings are generally better as a single string
#174: FILE: tools/testing/selftests/x86/test_FISTTP.c:69:
+ " fisttps res16""\n"
WARNING: Consecutive strings are generally better as a single string
#183: FILE: tools/testing/selftests/x86/test_FISTTP.c:91:
+ " fisttps res16""\n"
total: 0 errors, 5 warnings, 32 lines checked
Can you take a look at these and see if they can be fixed. Send me
v5 with these fixed - I will pull these in for 6.11-rc1
thanks,
-- Shuah
Hi Shuah,
These warnings are pre-existing. For such things, it's usually prudent
to avoid changing them--or at least, not in the same patch.
I think it's best to submit the patch (and series) as-is. If the x86
team wants the above things cleaned up (which I seriously doubt), they'll
let us know.
Yes?
thanks,
--
John Hubbard
NVIDIA
