On Mon, Jul 08, 2024 at 02:27:45PM GMT, Aaron Conole wrote: > Adrian Moreno <amorenoz@xxxxxxxxxx> writes: > > > There are a couple of places where the test script "sleep"s to wait for > > some external condition to be met. > > > > This is error prone, specially in slow systems (identified in CI by > > "KSFT_MACHINE_SLOW=yes"). > > > > To fix this, add a "ovs_wait" function that tries to execute a command > > a few times until it succeeds. The timeout used is set to 5s for > > "normal" systems and doubled if a slow CI machine is detected. > > > > This should make the following work: > > > > $ vng --build \ > > --config tools/testing/selftests/net/config \ > > --config kernel/configs/debug.config > > > > $ vng --run . --user root -- "make -C tools/testing/selftests/ \ > > KSFT_MACHINE_SLOW=yes TARGETS=net/openvswitch run_tests" > > > > Signed-off-by: Adrian Moreno <amorenoz@xxxxxxxxxx> > > --- > > Looks like this does resolve the issue in question on the -dbg > environment: > > https://netdev.bots.linux.dev/contest.html?executor=vmksft-net-dbg&test=openvswitch-sh Nice! I guess the 10s global timeout is enough for now. > > Thanks Adrian! Also, thanks for including the fractional sleep. > > Reviewed-by: Aaron Conole <aconole@xxxxxxxxxx> > Thanks. I just realized that I've missed the target branch ("net-next") in the subject. I'll wait a bit and respin to fix that. Adrián
