On 7/5/24 11:58, John Hubbard wrote:
On 7/5/24 10:53, Shuah Khan wrote:
On 7/3/24 20:33, John Hubbard wrote:
There were a couple of errors here:
1. TEST_GEN_PROGS was incorrectly prepending $(OUTPUT) to each program
to be built. However, lib.mk already does that because it assumes "bare"
program names are passed in, so this ended up creating
$(OUTPUT)/$(OUTPUT)/file.c, which of course won't work as intended.
2. lib.mk was included before TEST_GEN_PROGS was set, which led to
lib.mk's "all:" target not seeing anything to rebuild.
So nothing worked, which caused the author to force things by creating
an "all:" target locally--while still including ../lib.mk.
Fix all of this by including ../lib.mk at the right place, and removing
the $(OUTPUT) prefix to the programs to be built, and removing the
duplicate "all:" target.
Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
Why does the summary say mm ?
This is a mistake. I was also preparing some mm work at the time,
and typed the wrong thing.
Could you fix it up to s/mm/vDSO/ for me? Or if it's easier, I can send
an updated patch, let me know.
Send me updated patch - it will be easier that way. I saw the note
about getting these into 6.10 - As soon as you send the patch I will
apply them and send them for 6.10
thanks,
-- Shuah
