On 2024-07-02 at 15:20:22 -0700, Reinette Chatre wrote: >Hi Maciej, > >On 7/1/24 7:18 AM, Maciej Wieczor-Retman wrote: >... >> +int snc_nodes_per_l3_cache(void) >> +{ >> + int node_cpus, cache_cpus, i, ret = 1; >> + >> + node_cpus = count_sys_bitmap_bits("/sys/devices/system/node/node0/cpumap"); >> + cache_cpus = count_sys_bitmap_bits("/sys/devices/system/cpu/cpu0/cache/index3/shared_cpu_map"); >> + >> + if (!node_cpus || !cache_cpus) { >> + ksft_print_msg("Could not determine Sub-NUMA Cluster mode!\n"); > >nit: could you please check this series and remove exclamation marks from the messages >printed to user space? Just stating the error should be sufficient. Sure, will do. > >Reinette -- Kind regards Maciej Wieczór-Retman