On 6/19/24 19:09, Jeff Johnson wrote:
On 6/18/24 10:03, Ivan Orlov wrote:
Currently, the only way to build string-stream-test is by setting
CONFIG_KUNIT_TEST=y. However, CONFIG_KUNIT_TEST is a config option for
a different test (`kunit-test.c`).
Introduce a new Kconfig entry in order to be able to build the
string-stream-test test as a separate module. Import the KUnit namespace
in the test so we could have string-stream functions accessible.
Reviewed-by: David Gow <davidgow@xxxxxxxxxx>
Signed-off-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
---
V1 -> V2:
- No changes
lib/kunit/Kconfig | 8 ++++++++
lib/kunit/Makefile | 2 +-
lib/kunit/string-stream-test.c | 2 ++
3 files changed, 11 insertions(+), 1 deletion(-)
...
diff --git a/lib/kunit/string-stream-test.c
b/lib/kunit/string-stream-test.c
index 7511442ea98f..d03cac934e04 100644
--- a/lib/kunit/string-stream-test.c
+++ b/lib/kunit/string-stream-test.c
@@ -534,3 +534,5 @@ static struct kunit_suite string_stream_test_suite
= {
.init = string_stream_test_init,
};
kunit_test_suites(&string_stream_test_suite);
+MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
+MODULE_LICENSE("GPL");
missing MODULE_DESCRIPTION()
this will cause a warning with make W=1
Hi Jeff,
Thank you for noticing this, I'm going to add the MODULE_DESCRIPTION in
the V3 of this patch series.
--
Kind regards,
Ivan Orlov
