On 6/21/24 22:38, Rae Moar wrote:
On Tue, Jun 18, 2024 at 1:03 PM Ivan Orlov <ivan.orlov0322@xxxxxxxxx> wrote:
Since assert_test covers the part of the KUnit core (the assertion
formatting functions), I believe it would be better to have it merged
into kunit-test (as it is done for other tests for the KUnit core).
Signed-off-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
Hello!
This looks good to me. I don't know if it was necessary to move the
assert tests but I definitely see the reasoning. Happy with this as it
is. There are a few checkpatch warnings I have mentioned below but I
think the use case makes it necessary.
Reviewed-by: Rae Moar <rmoar@xxxxxxxxxx>
Thanks!
-Rae
Hi Rae,
Thank you so much for the review, and sorry for the late reply ( I've
been on vacation this week, and didn't have access to my inbox :( ).
And yes, since we want to get the actual pointer address "%px" is our
only option :(
--
Kind regards,
Ivan Orlov
