Re: [PATCH v4 2/4] mm/memory-failure: userspace controls soft-offlining pages

[Miaohe Lin <linmiaohe@xxxxxxxxxx>]

On 2024/6/21 2:48, Jiaqi Yan wrote:
> Correctable memory errors are very common on servers with large
...
>  
>  /*
> @@ -2749,8 +2760,9 @@ static int soft_offline_in_use_page(struct page *page)
>   * @pfn: pfn to soft-offline
>   * @flags: flags. Same as memory_failure().
>   *
> - * Returns 0 on success
> - *         -EOPNOTSUPP for hwpoison_filter() filtered the error event
> + * Returns 0 on success,
> + *         -EOPNOTSUPP for hwpoison_filter() filtered the error event,
> + *         -EOPNOTSUPP if disabled by /proc/sys/vm/enable_soft_offline,

No strong opinion, but it might be better to write as "or disabled by /proc/sys/vm/enable_soft_offline".

Acked-by: Miaohe Lin <linmiaohe@xxxxxxxxxx>
Thanks.
.