Re: [PATCH v2 4/6] kselftest/alsa: mixer-test: Skip write verification for volatile controls

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 14, 2024 at 05:37:13PM +0200, Takashi Iwai wrote:

> @@ -616,6 +616,10 @@ static int write_and_verify(struct ctl_data *ctl,
>  	if (!snd_ctl_elem_info_is_readable(ctl->info))
>  		return err;
>  
> +	/* Skip the verification for volatile controls, too */
> +	if (snd_ctl_elem_info_is_volatile(ctl->info))
> +		return err;
> +

I think we should do the checks in test_ctl_get_value() still - a read
and then ctl_value_is_valid() on whatever we read.  It doesn't need to
match the value we wrote but it should still be valid for the control.

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux