On Tue, Apr 30, 2024, Chao Gao wrote:
> On Thu, Feb 08, 2024 at 01:26:35AM +0800, Xin Li wrote:
> >@@ -6449,6 +6451,19 @@ void dump_vmcs(struct kvm_vcpu *vcpu)
> > vmx_dump_sel("LDTR:", GUEST_LDTR_SELECTOR);
> > vmx_dump_dtsel("IDTR:", GUEST_IDTR_LIMIT);
> > vmx_dump_sel("TR: ", GUEST_TR_SELECTOR);
> >+#ifdef CONFIG_X86_64
> >+ if (kvm_is_fred_enabled(vcpu)) {
>
> FRED MSRs are accessible even if CR4.FRED isn't set and #ifdef is ugly, I think
> you can simply do:
>
> if (vmentry_ctrl & VM_ENTRY_LOAD_IA32_FRED)
>
> just like below handling for EFER/PAT etc.
+1
