Re: [PATCH] selftests: filesystems: fix warn_unused_result build warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/3/24 05:17, Amer Al Shanawany wrote:
On 5/4/24 19:17, Amer Al Shanawany wrote:
On 4/19/24 18:41, Muhammad Usama Anjum wrote:
On 4/17/24 11:49 PM, Amer Al Shanawany wrote:
Fix the following warnings by adding return check and error messages.

statmount_test.c: In function ‘cleanup_namespace’:
statmount_test.c:128:9: warning: ignoring return value of ‘fchdir’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
   128 |         fchdir(orig_root);
       |         ^~~~~~~~~~~~~~~~~
statmount_test.c:129:9: warning: ignoring return value of ‘chroot’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
   129 |         chroot(".");
       |         ^~~~~~~~~~~

Signed-off-by: Amer Al Shanawany <amer.shanawany@xxxxxxxxx>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>

---
  .../selftests/filesystems/statmount/statmount_test.c | 12 ++++++++++--
  1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/tools/testing/selftests/filesystems/statmount/statmount_test.c b/tools/testing/selftests/filesystems/statmount/statmount_test.c
index e6d7c4f1c85b..e8c019d72cbf 100644
--- a/tools/testing/selftests/filesystems/statmount/statmount_test.c
+++ b/tools/testing/selftests/filesystems/statmount/statmount_test.c
@@ -125,8 +125,16 @@ static uint32_t old_root_id, old_parent_id;
static void cleanup_namespace(void)
  {
-	fchdir(orig_root);
-	chroot(".");
+	int ret;
+
+	ret = fchdir(orig_root);
+	if (ret == -1)
+		ksft_perror("fchdir to original root");
+
+	ret = chroot(".");
+	if (ret == -1)
+		ksft_perror("chroot to original root");
+
  	umount2(root_mntpoint, MNT_DETACH);
  	rmdir(root_mntpoint);
  }
Hi,

Can you please consider this patch?

Thank  you

Amer



Hello,

Could you please consider this simple patch for fixing build warnings for kselftest ?

Thank you

Amer

Applied to linux-kselftest fixes branch for the next rc.

thanks,
-- Shuah







[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux