Re: [PATCH 5/5] kunit: Merge assertion test into kunit-test.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 6/8/24 10:20, David Gow wrote:
On Tue, 4 Jun 2024 at 20:32, Ivan Orlov <ivan.orlov0322@xxxxxxxxx> wrote:

Since assert_test covers the part of the KUnit core (the assertion
formatting functions), I believe it would be better to have it merged
into kunit-test (as it is done for other tests for the KUnit core).

Signed-off-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
---

Personally, I don't mind if the assert tests are in a separate file,
but do think it's worth having them in the same module.

Do you think it'd be better to keep them as separate source files (but
put them in the same module via the Makefile), or is having a single
source file cleaner?

Either way, I think this should be merged with the previous patch (see
my comments there.)


Hi David,

Thank you for the review and sorry for the late reply.

I believe having the assert test in the same file as other kunit core tests would be more consistent with the existing test structure (otherwise, the tests for other parts of the kunit core should be extracted to separate files as well).

What do you think is more appropriate?

--
Kind regards,
Ivan Orlov





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux