On Mon, 10 Jun 2024, Moger, Babu wrote: > On 6/10/24 11:20, Ilpo Järvinen wrote: > > On Mon, 10 Jun 2024, Babu Moger wrote: > > > >> The selftest noncont_cat_run_test fails on AMD with the warnings. Reason > > > > noncont_cat_run_test() > > I want to mention the test here. not function. How about this? > > "The selftest non-contiguous CBM test fails on AMD with the warnings." Yes, it's possible to refer to something with natural language (in fact, I personally find that better than using a function name when both options exist). The underscores are C artifacts to replace spaces that do not belong to natural language so if one uses underscores, I'll always take it as a direct reference to C code. The quote still has "the warnings" though (but I see Reinette already noted that). > > (In general, use () when refering to a function, same thing in the > > shortlog). > > > > "the warnings" sounds like I should know about what warning it fails with > > but there's no previous context which tells that information. I suggest > > you either use "a warning" or quote the warning it fails with into the > > commit message. > > > >> is, AMD supports non contiguous CBM masks but does not report it via CPUID. -- i.
