Re: [PATCH] selftests: proc: remove unreached code and fix build warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 3 Jun 2024 17:24:47 +0300 Alexey Dobriyan <adobriyan@xxxxxxxxx> wrote:

> On Mon, Jun 03, 2024 at 02:42:20PM +0200, Amer Al Shanawany wrote:
> > fix the following warning:
> > proc-empty-vm.c:385:17: warning: ignoring return value of ‘write’
> 
> > --- a/tools/testing/selftests/proc/proc-empty-vm.c
> > +++ b/tools/testing/selftests/proc/proc-empty-vm.c
> > @@ -381,9 +381,6 @@ static int test_proc_pid_statm(pid_t pid)
> 
> > -	if (0) {
> > -		write(1, buf, rv);
> > -	}
> 
> no thanks

Why not?

Why does that code exist anyway?  It at least needs a comment.




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux