On Tue, 2024-06-04 at 14:10 -0400, Joe Lawrence wrote: > On Mon, Jun 03, 2024 at 02:26:19PM -0300, Marcos Paulo de Souza > wrote: > > Adapt the current test-livepatch.sh script to account the number of > > applied livepatches and ensure that an atomic replace livepatch > > disables > > all previously applied livepatches. > > > > Signed-off-by: Marcos Paulo de Souza <mpdesouza@xxxxxxxx> > > --- > > Changes since v2: > > * Used variables to stop the name of other livepatches applied to > > test > > the atomic replace. (Joe) > > > > Changes since v1: > > * Added checks in the existing test-livepatch.sh instead of > > creating a > > new test file. (Joe) > > * Fixed issues reported by ShellCheck (Joe) > > --- > > Changes in v3: > > - EDITME: describe what is new in this series revision. > > - EDITME: use bulletpoints and terse descriptions. > > - Link to v2: > > https://lore.kernel.org/r/20240525-lp-atomic-replace-v2-1-142199bb65a1@xxxxxxxx > > --- > > .../testing/selftests/livepatch/test-livepatch.sh | 138 > > +++++++++++++-------- > > 1 file changed, 89 insertions(+), 49 deletions(-) > > > > diff --git a/tools/testing/selftests/livepatch/test-livepatch.sh > > b/tools/testing/selftests/livepatch/test-livepatch.sh > > index e3455a6b1158..ca770b8c62fc 100755 > > --- a/tools/testing/selftests/livepatch/test-livepatch.sh > > +++ b/tools/testing/selftests/livepatch/test-livepatch.sh > > > > [ ... snip ... ] > > > > # - load a livepatch that modifies the output from /proc/cmdline > > and > > # verify correct behavior > > -# - load an atomic replace livepatch and verify that only the > > second is active > > -# - remove the first livepatch and verify that the atomic replace > > livepatch > > -# is still active > > +# - load two addtional livepatches and check the number of > > livepatch modules > > nit: s/addtional/additional as Miroslav spotted in v2 > > Otherwise LGTM, > > Acked-by: Joe Lawrence <joe.lawrence@xxxxxxxxxx> Thanks Joe! I forgot to address Miroslav's comment... Petr, would you fix it locally? Thanks! > > -- > Joe >
