Hi Hangbin, > On Wed, May 29, 2024 at 04:22:32PM +0200, Lukasz Majewski wrote: > > Fixed MAC addresses help with debugging as last four bytes identify > > the network namespace. > > > > Moreover, it allows to mimic the real life setup with for example > > bridge having the same MAC address on each port. > > > > Signed-off-by: Lukasz Majewski <lukma@xxxxxxx> > > --- > > tools/testing/selftests/net/hsr/hsr_redbox.sh | 15 +++++++++++++++ > > 1 file changed, 15 insertions(+) > > > > diff --git a/tools/testing/selftests/net/hsr/hsr_redbox.sh > > b/tools/testing/selftests/net/hsr/hsr_redbox.sh index > > 1f36785347c0..998103502d5d 100755 --- > > a/tools/testing/selftests/net/hsr/hsr_redbox.sh +++ > > b/tools/testing/selftests/net/hsr/hsr_redbox.sh @@ -96,6 +96,21 @@ > > setup_hsr_interfaces() ip -n "${ns4}" link set ns4eth1 up > > ip -n "${ns5}" link set ns5eth1 up > > > > + ip -net "$ns1" link set address 00:11:22:00:01:01 dev > > ns1eth1 > > + ip -net "$ns1" link set address 00:11:22:00:01:02 dev > > ns1eth2 + > > + ip -net "$ns2" link set address 00:11:22:00:02:01 dev > > ns2eth1 > > + ip -net "$ns2" link set address 00:11:22:00:02:02 dev > > ns2eth2 > > + ip -net "$ns2" link set address 00:11:22:00:02:03 dev > > ns2eth3 + > > + ip -net "$ns3" link set address 00:11:22:00:03:11 dev > > ns3eth1 > > + ip -net "$ns3" link set address 00:11:22:00:03:11 dev > > ns3eth2 > > + ip -net "$ns3" link set address 00:11:22:00:03:11 dev > > ns3eth3 > > + ip -net "$ns3" link set address 00:11:22:00:03:11 dev > > ns3br1 > > The ns3's mac addresses are same, is it a copy-paste error? > No, it is to mimic the switch behaviour. > BTW, please add the target tree for the patch, e.g. > > [PATCH net-next] Ok. > > Thanks > Hangbin Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Erika Unter HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx
Attachment:
pgpsMDnWaE3kz.pgp
Description: OpenPGP digital signature