On 5/31/24 1:00 AM, John Hubbard wrote: > On 5/30/24 12:46 PM, Dave Hansen wrote: >> On 5/27/24 14:00, John Hubbard wrote: >>> John Hubbard (6): >>> selftests/x86: build test_FISTTP.c with clang >>> selftests/x86: build fsgsbase_restore.c with clang >>> selftests/x86: build sysret_rip.c with clang >>> selftests/x86: avoid -no-pie warnings from clang during compilation >>> selftests/x86: remove (or use) unused variables and functions >>> selftests/x86: fix printk warnings reported by clang >> >> John, could you and Muhammad have a chat and perhaps settle on a series >> series that gets acks from both of you? >> >>> https://lore.kernel.org/all/20240501122918.3831734-1-usama.anjum@xxxxxxxxxxxxx/ >> >> I had Muhammad's in my queue and didn't realize we had two overlapping >> series' bouncing around until now. > > Aha OK. Muhummad, after looking through this, I see that our > test_FISTTP.c fix is identical, and that's about it. My series goes > a bit deeper IMHO and completely fixes all the errors; the tradeoff > is that it is more intrusive. Which I think is appropriate. > > Would you be OK with my posting v3 that uses your patch for > test_FISTTP.c [1], and the rest of my patches for the rest? Yeah, sure go ahead. I'll test/review the v3 series. > > > [1] > https://lore.kernel.org/all/20240501122918.3831734-7-usama.anjum@xxxxxxxxxxxxx/ > > thanks, -- BR, Muhammad Usama Anjum