Re: [PATCH v2 2/3] selftests/futex: don't pass a const char* to asprintf(3)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/30/24 2:13 PM, Shuah Khan wrote:
On 5/30/24 13:16, John Hubbard wrote:
On 5/30/24 12:04 PM, Shuah Khan wrote:
On 5/28/24 20:29, John Hubbard wrote:
When building with clang, via:

     make LLVM=1 -C tools/testing/selftests

...clang issues a warning, because test_name is passed into asprintf(3),
which then changes it.

Please include the warning in the commit log.

Ah, OK, the warning is:

futex_requeue_pi.c:403:17: warning: passing 'const char **' to parameter
of type 'char **' discards qualifiers in nested pointer types
[-Wincompatible-pointer-types-discards-qualifiers]


Please let me know if you'd prefer a v3, or if you'd rather fix it
up, whatever seems easiest for you.


Yes please send me v3.


OK, coming soon, hopefully a bit later today, in fact.

thanks,
--
John Hubbard
NVIDIA





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux