Hi Ilpo, On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
write_bm_pid_to_resctrl() uses resctrl_val to check test name which is not a good interface generic resctrl FS functions should provide. Only MBM and CMT tests define mongrp so the test name check in write_bm_pid_to_resctrl() can be changed to depend simply on mongrp being non-NULL.
Second paragraph needs to be reworked because at this point "Only MBM and CMT tests define mongrp" is not accurate. Perhaps just (feel free to improve): Tests define mongrp when needed. Remove the test name check in write_bm_pid_to_resctrl() to only rely on mongrp being non-NULL.
With last user of resctrl_val gone, the parameter and member from the struct resctrl_val_param can removed. Test name constants can also be removed because they are not used anymore.
Imperative tone needed.
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> ---
Patch looks good. Thank you. Reinette
