Re: [PATCH v4 05/16] selftests/resctrl: Use correct type for pids

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ilpo,

On 5/20/24 5:30 AM, Ilpo Järvinen wrote:
A few functions receive PIDs through int arguments. PIDs variables
should be of type pid_t, not int.

Convert pid arguments from int to pid_t.


This looks good to me. A couple of places remain that treat
pid_t as int ... that is via the %d format specifier
used to do the printing in print_results_cache() as well as
print_results_bw(). I understand we do not see any warnings
since these are indeed int. So, I wonder if an explicit (int) cast
would not make things obvious and match the stated goal of
not treating pid_t as int?

Reinette




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux