RE: [PATCH bpf-next 2/8] selftests/bpf: Drop duplicate definition of i in test_sockmap

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Geliang Tang <geliang@xxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Jakub Sitnicki <jakub@xxxxxxxxxxxxxx>
Subject: RE: [PATCH bpf-next 2/8] selftests/bpf: Drop duplicate definition of i in test_sockmap
From: John Fastabend <john.fastabend@xxxxxxxxx>
Date: Mon, 27 May 2024 10:03:31 -0700
Cc: Geliang Tang <tanggeliang@xxxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <8d690682330a59361562bca75d6903253d16f312.1716446893.git.tanggeliang@kylinos.cn>

Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@xxxxxxxxxx>
> 
> There's already a definition of i in run_options() at the beginning, no
> need to define a new one in "if (tx_prog_fd > 0)" block.
> 
> Signed-off-by: Geliang Tang <tanggeliang@xxxxxxxxxx>
> ---

Acked-by: John Fastabend <john.fastabend@xxxxxxxxx>

References:
- [PATCH bpf-next 0/8] fixes for test_sockmap
  - From: Geliang Tang
- [PATCH bpf-next 2/8] selftests/bpf: Drop duplicate definition of i in test_sockmap
  - From: Geliang Tang

Prev by Date: Re: [RFC PATCH v4 5/5] KVM: riscv: selftests: Add Svadu Extension to get-reg-list testt
Next by Date: RE: [PATCH bpf-next 1/8] selftests/bpf: Fix tx_prog_fd values in test_sockmap
Previous by thread: [PATCH bpf-next 2/8] selftests/bpf: Drop duplicate definition of i in test_sockmap
Next by thread: [PATCH bpf-next 3/8] selftests/bpf: Use bpf_link attachments in test_sockmap
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]