On Thu, May 16, 2024 at 08:53:52AM -0600, Shuah Khan wrote:
> On 5/16/24 08:02, Mark Brown wrote:
> > I'm seeing quite a lot of breakage in mainline as a result of
> > daef47b89efd0b7 ("selftests: Compile kselftest headers with
> > -D_GNU_SOURCE") and daef47b89efd0 ("selftests: Compile kselftest headers
> > with -D_GNU_SOURCE") - thus far I've found that the use of
> > static_assert() is triggering build breaks where testsuites aren't
> > picking up the addition of _GNU_SOURCE (including stopping installing
> > the other tests in the same directory), and there's a bunch of tests
> > which #define _GNU_SOURCE in their code and now trigger build warnings.
> > I'm looking at fixes and mitigations now.
> Would it be better to revert this for now and get this for now? I wouldn't
> want you to extra busy work to workaround this.
I have patches that both fix the build breakage (it turns out on closer
inspection that it's just ALSA that's impacted I think, the extensive
extra warning splat and some other stuff that's just updates in
mainline) was making the impact look wider) and deescalate it to a
#warning which I'm currently running through CI.
> > The build failures are taking out the ALSA tests entirely which has
> > caused my personal CI to explode badly :/
> This has been in next for a while and I didn't see any failures. These
> kind of changes are tricky. On second thought, I probably should have
> delayed picking this up.
Yeah, I'd been on holiday for literally a month (got home Monday night)
- once I saw the issues I realised I had registered them going past at
some point while I was away but hadn't really been paying attention to
what was going on in -next. I'm kind of surprised nobody else picked up
on the warnings though.
Attachment:
signature.asc
Description: PGP signature
