Re: [PATCH net-next] selftests: net: use upstream mtools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 10, 2024 at 07:24:24AM -0700, Jakub Kicinski wrote:
> On Fri, 10 May 2024 14:28:56 +0300 Vladimir Oltean wrote:
> > Check that the deployed mtools version is 3.0 or above. Note that the
> > version check breaks compatibility with my fork 
> 
> And Joachim's tree from before the tag, the PR was merged a while back
> ;)

Yet "git tag --contains <the pull request>" shows "v3.0". I have no
other reliable way of determining whether IPv6 is supported. Maybe look
at msend -h | grep '\-6'.

> > where I didn't bump the version, but I assume that won't be a problem.
> 
> Agreed, no point accumulating more bespoke checks.
> I updated NIPA, next run should have tagged 3.0.
> 
> Speaking of requirement checks - I run the test on a fresh Fedora
> install yesterday and it was failing with no indication of why.
> Then I realized tcpdump wasn't installed :(

Huh, for me, "why isn't this running properly?" ends up being answered
by the following Kconfig options not being active:

CONFIG_IP_ADVANCED_ROUTER=y
CONFIG_IP_MULTIPLE_TABLES=y
CONFIG_NET_L3_MASTER_DEV=y
CONFIG_IPV6=y
CONFIG_IPV6_MULTIPLE_TABLES=y
CONFIG_NET_VRF=y




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux