Re: [PATCH net-next] selftests: net: local_termination: annotate the expected failures

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 09, 2024 at 04:55:53PM -0700, Jakub Kicinski wrote:
> diff --git a/tools/testing/selftests/net/forwarding/local_termination.sh b/tools/testing/selftests/net/forwarding/local_termination.sh
> index c5b0cbc85b3e..4bba9c78db3e 100755
> --- a/tools/testing/selftests/net/forwarding/local_termination.sh
> +++ b/tools/testing/selftests/net/forwarding/local_termination.sh
> @@ -73,6 +73,10 @@ check_rcv()
>  	local pattern=$3
>  	local should_receive=$4
>  	local should_fail=
> +	local xfail_sw=$5
> +
> +	local kind=$(ip -j -d link show dev $if_name |
> +			 jq -r '.[].linkinfo.info_kind')
>  
>  	[ $should_receive = true ] && should_fail=0 || should_fail=1
>  	RET=0
> @@ -81,7 +85,14 @@ check_rcv()
>  
>  	check_err_fail "$should_fail" "$?" "reception"
>  
> -	log_test "$if_name: $type"
> +	# If not a SW interface, ignore the XFAIL allowance
> +	[ "$kind" != veth ] && [ "$kind" != bridge ] && xfail_sw=
> +
> +	if [ $RET -ne 0 ] && [ "$xfail_sw" == true ]; then
> +	    log_test_xfail "$if_name: $type"
> +	else
> +	    log_test "$if_name: $type"
> +	fi
>  }

I just wish IFF_UNICAST_FLT was available to user space.

Reviewed-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>
Tested-by: Vladimir Oltean <vladimir.oltean@xxxxxxx>




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux