On 5/8/24 1:00 AM, Ilpo Järvinen wrote:
On Tue, 7 May 2024, Reinette Chatre wrote:
Hi John,
On 5/7/2024 6:25 PM, John Hubbard wrote:
On 5/7/24 6:21 PM, Reinette Chatre wrote:
Hi John,
...
Yes, there are two *abs() calls in this function.
In this case is okay to remove the first one since it didn't remove
absolute value completely, whereas in the MBA/MBM cases v1 removed *abs()
call entirely which was wrong thing to do.
I explicitly noted in my v1 comment that this CMT change is okay but the
other two were not.
Got it, thanks Ilpo (and Reinette), I'll send a v3 with it fixed up
accordingly, appreciate your patience here. :)
thanks,
--
John Hubbard
NVIDIA
