Re: [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jakub Kicinski <kuba@xxxxxxxxxx>
Subject: Re: [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions
From: Mickaël Salaün <mic@xxxxxxxxxxx>
Date: Mon, 29 Apr 2024 21:18:50 +0200
Cc: Kees Cook <keescook@xxxxxxxxxxxx>, Christian Brauner <brauner@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, Shengyu Li <shengyu.li.evgeny@xxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, "David S . Miller" <davem@xxxxxxxxxxxxx>, Günther Noack <gnoack@xxxxxxxxxx>, Will Drewry <wad@xxxxxxxxxxxx>, kernel test robot <oliver.sang@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <20240429101647.756a1ac7@kernel.org>

On Mon, Apr 29, 2024 at 10:16:47AM -0700, Jakub Kicinski wrote:
> On Mon, 29 Apr 2024 08:52:36 -0700 Kees Cook wrote:
> > > +/* Wait for the child process to end but without sharing memory mapping. */
> > > +static pid_t __attribute__((__unused__)) clone3_vfork(void)  
> > 
> > Why "unused"?
> 
> Right, static inline is enough

Indeed, I'll fix that.

References:
- [PATCH v2 0/5] Fix Kselftest's vfork() side effects
  - From: Mickaël Salaün
- [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions
  - From: Mickaël Salaün
- Re: [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions
  - From: Kees Cook
- Re: [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions
  - From: Jakub Kicinski

Prev by Date: Re: [PATCH v2 bpf-next 4/6] selftests/bpf: Add IPv4 and IPv6 sockaddr test cases
Next by Date: [PATCH v3 0/9] Fix Kselftest's vfork() side effects
Previous by thread: Re: [PATCH v2 4/9] selftests/harness: Fix interleaved scheduling leading to race conditions
Next by thread: [PATCH v2 6/9] selftests/harness: Constify fixture variants
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]