Hi Ilpo, On 4/8/2024 9:32 AM, Ilpo Järvinen wrote: > initialize_mem_bw_resctrl() and set_mbm_path() contain complicated set > of conditions, each yielding different file to be opened to measure > memory bandwidth through resctrl FS. In practice, only two of them are > used. For MBA test, ctrlgrp is always provided, and for MBM test both > ctrlgrp and mongrp are set. > > The file used differ between MBA/MBM test, however, MBM test > unnecessarily create monitor group because resctrl FS already provides > monitoring interface underneath any ctrlgrp too, which is what the MBA > selftest uses. > > Consolidate memory bandwidth file used to the one used by the MBA > selftest. Remove all unused branches opening other files to simplify > the code. This is a good change but it seems incomplete to me. As changelog states MBM creates monitor group unnecessarily, but from what I can tell it continues to do so after this change. It is also optimized in patch 16, which I think may end up being dropped as part of cleaning this up (here and for the CMT test). Reinette
