On Tue, Apr 23, 2024 at 05:08:06PM +0800, David Gow wrote: > The NULL dereference tests in kunit_fault deliberately trigger a kernel > BUG(), and therefore print the associated stack trace, even when the > test passes. This is both annoying (as it bloats the test output), and > can confuse some test harnesses, which assume any BUG() is a failure. > > Allow these tests to be specifically disabled (without disabling all > of KUnit's other tests), by placing them behind the > CONFIG_KUNIT_FAULT_TEST Kconfig option. This is enabled by default, but > can be set to 'n' to disable the test. An empty 'kunit_fault' suite is > left behind, which will automatically be marked 'skipped'. > > As the fault tests already were disabled under UML (as they weren't > compatible with its fault handling), we can simply adapt those > conditions, and add a dependency on !UML for our new option. > > Suggested-by: Guenter Roeck <linux@xxxxxxxxxxxx> > Link: https://lore.kernel.org/all/928249cc-e027-4f7f-b43f-502f99a1ea63@xxxxxxxxxxxx/ > Fixes: 82b0beff3497 ("kunit: Add tests for fault") > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> Reviewed-and-tested-by: Guenter Roeck <linux@xxxxxxxxxxxx> Thanks! Guenter
