Re: [PATCH bpf-next v2 11/14] selftests/bpf: Use start_server_setsockopt in sockopt_inherit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Martin KaFai Lau <martin.lau@xxxxxxxxx>, Geliang Tang <geliang@xxxxxxxxxx>
Subject: Re: [PATCH bpf-next v2 11/14] selftests/bpf: Use start_server_setsockopt in sockopt_inherit
From: Eduard Zingerman <eddyz87@xxxxxxxxx>
Date: Fri, 12 Apr 2024 20:35:48 +0300
Cc: Geliang Tang <tanggeliang@xxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <4d19829e-6e96-445f-8e2a-47f58b921281@linux.dev>
User-agent: Evolution 3.44.4-0ubuntu2

On Thu, 2024-04-11 at 15:10 -0700, Martin KaFai Lau wrote:

[...]

> The start_server_setsockopt is only limited to integer socket option. It is not 
> very flexible. It seems this is the only test that will be useful. Lets drop 
> start_server_setsockopt addition from this set for now and discuss it separately.

I agree with this suggestion from Martin.

[...]

References:
- [PATCH bpf-next v2 00/14] use start_server and connect_to helpers
  - From: Geliang Tang
- [PATCH bpf-next v2 11/14] selftests/bpf: Use start_server_setsockopt in sockopt_inherit
  - From: Geliang Tang
- Re: [PATCH bpf-next v2 11/14] selftests/bpf: Use start_server_setsockopt in sockopt_inherit
  - From: Martin KaFai Lau

Prev by Date: Re: [PATCH 07/19] riscv: Optimize riscv_cpu_isa_extension_(un)likely()
Next by Date: Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers
Previous by thread: Re: [PATCH bpf-next v2 11/14] selftests/bpf: Use start_server_setsockopt in sockopt_inherit
Next by thread: [PATCH bpf-next v2 12/14] selftests/bpf: Use connect_to_fd in sockopt_inherit
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]