Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Richard Gobert <richardbgobert@xxxxxxxxx>
Subject: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive
From: Eric Dumazet <edumazet@xxxxxxxxxx>
Date: Tue, 26 Mar 2024 15:14:55 +0100
Cc: davem@xxxxxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, willemdebruijn.kernel@xxxxxxxxx, dsahern@xxxxxxxxxx, xeb@xxxxxxx, shuah@xxxxxxxxxx, idosch@xxxxxxxxxx, amcohen@xxxxxxxxxx, petrm@xxxxxxxxxx, jbenc@xxxxxxxxxx, bpoirier@xxxxxxxxxx, b.galvani@xxxxxxxxx, liujian56@xxxxxxxxxx, horms@xxxxxxxxxx, linyunsheng@xxxxxxxxxx, therbert@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx
In-reply-to: <20240325182543.87683-5-richardbgobert@gmail.com>

On Mon, Mar 25, 2024 at 7:27 PM Richard Gobert <richardbgobert@xxxxxxxxx> wrote:
>
> {inet,ipv6}_gro_receive functions perform flush checks (ttl, flags,
> iph->id, ...) against all packets in a loop. These flush checks are used
> currently only in tcp flows in GRO.

I think this is a bug.

GRO should not aggregate packets if their ttl/tos fields do not match.

Follow-Ups:
- Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive
  - From: Richard Gobert

References:
- [PATCH net-next v4 0/4] net: gro: encapsulation bug fix and flush checks improvements
  - From: Richard Gobert
- [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive
  - From: Richard Gobert

Prev by Date: Re: [PATCH net] selftests: netdevsim: set test timeout to 10 minutes
Next by Date: Re: [PATCH] kunit: configs: Enable CONFIG_DAMON_DBGFS_DEPRECATED for --alltests
Previous by thread: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive
Next by thread: Re: [PATCH net-next v4 4/4] net: gro: move L3 flush checks to tcp_gro_receive
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]