Hi Sean, Thank you for reviewing my patches On 3/7/2024 8:00 PM, Sean Christopherson wrote: > On Thu, Mar 07, 2024, Manali Shukla wrote: >> From: Manali Shukla <Manali.Shukla@xxxxxxx> >> >> The Idle HLT intercept feature allows for the HLT instruction execution >> by a vCPU to be intercepted by hypervisor only if there are no pending >> V_INR and V_NMI events for the vCPU. The Idle HLT intercept will not be >> triggerred when vCPU is expected to service pending events (V_INTR and >> V_NMI). >> >> The new SVM_EXIT_IDLE_HLT is introduced as part of the Idle HLT >> intercept feature. Add it to SVM_EXIT_REASONS, so that the >> SVM_EXIT_IDLE_HLT type of VMEXIT is recognized by tools like perf etc. >> >> Signed-off-by: Manali Shukla <Manali.Shukla@xxxxxxx> >> --- >> tools/arch/x86/include/uapi/asm/svm.h | 2 ++ > > Please drop the tools/ uapi headers update. Nothing KVM-related in tools/ > actually relies on the headers being copied into tools/, e.g. KVM selftests > pulls KVM's headers from the .../usr/include/ directory that's populated by > `make headers_install`. > > Perf's tooling is what actually "needs" the headers to be copied into tools/; > let the tools/perf maintainers deal with the headache of keeping everything up-to-date. Sure I will drop this patch in V2. -Manali
