Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx>
Subject: Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline
From: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
Date: Mon, 11 Mar 2024 08:33:10 -0700
Cc: Ian Rogers <irogers@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Peter Zijlstra <peterz@xxxxxxxxxxxxx>, Ingo Molnar <mingo@xxxxxxxxxx>, Arnaldo Carvalho de Melo <acme@xxxxxxxxxx>, Namhyung Kim <namhyung@xxxxxxxxxx>, Mark Rutland <mark.rutland@xxxxxxx>, Alexander Shishkin <alexander.shishkin@xxxxxxxxxxxxxxx>, Adrian Hunter <adrian.hunter@xxxxxxxxx>, Paolo Bonzini <pbonzini@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Kees Cook <keescook@xxxxxxxxxxxx>, "Gustavo A. R. Silva" <gustavoars@xxxxxxxxxx>, Nathan Chancellor <nathan@xxxxxxxxxx>, Bill Wendling <morbo@xxxxxxxxxx>, Justin Stitt <justinstitt@xxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>, Liam Howlett <liam.howlett@xxxxxxxxxx>, Miguel Ojeda <ojeda@xxxxxxxxxx>, Will Deacon <will@xxxxxxxxxx>, Mark Brown <broonie@xxxxxxxxxx>, David Laight <David.Laight@xxxxxxxxxx>, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Shunsuke Mie <mie@xxxxxxxxxx>, Yafang Shao <laoar.shao@xxxxxxxxx>, Kui-Feng Lee <kuifeng@xxxxxxxx>, James Clark <james.clark@xxxxxxx>, Nick Forrington <nick.forrington@xxxxxxx>, Leo Yan <leo.yan@xxxxxxxxx>, German Gomez <german.gomez@xxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, John Garry <john.g.garry@xxxxxxxxxx>, Sean Christopherson <seanjc@xxxxxxxxxx>, Anup Patel <anup@xxxxxxxxxxxxxx>, Fuad Tabba <tabba@xxxxxxxxxx>, Andrew Jones <ajones@xxxxxxxxxxxxxxxx>, Chao Peng <chao.p.peng@xxxxxxxxxxxxxxx>, Haibo Xu <haibo1.xu@xxxxxxxxx>, Peter Xu <peterx@xxxxxxxxxx>, Vishal Annapurve <vannapurve@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-arch@xxxxxxxxxxxxxxx, bpf@xxxxxxxxxxxxxxx, linux-perf-users@xxxxxxxxxxxxxxx, kvm@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-hardening@xxxxxxxxxxxxxxx, llvm@xxxxxxxxxxxxxxx, Christopher Di Bella <cjdb@xxxxxxxxxx>
In-reply-to: <CANiq72=rgXk6oz65wb57ZP+jmSoD-a4SSVzU6s6SZLubV3cvBw@mail.gmail.com>

On Sun, Mar 10, 2024 at 4:25 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Sun, Mar 10, 2024 at 3:06 AM Ian Rogers <irogers@xxxxxxxxxx> wrote:
> >
> > [1] https://clang.llvm.org/docs/AttributeReference.html#noinline
> > Reported-by: Christopher Di Bella <cjdb@xxxxxxxxxx>
>
> Out of curiosity, was this due to the `[[gnu::noinline]]` or similar
> in e.g. `src/string/memset_explicit.h`?

Yes, and in src/__support/threads/linux/thread.cpp's definition of
start_thread().

Thanks for the patch!

Acked-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

-- 
Thanks,
~Nick Desaulniers

References:
- [PATCH v1 00/13] tools header compiler.h update
  - From: Ian Rogers
- [PATCH v1 13/13] tools headers: Rename noinline to __noinline
  - From: Ian Rogers
- Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline
  - From: Miguel Ojeda

Prev by Date: Re: [PATCH bpf-next v2 8/9] libbpf: add support for the multi-link of tracing
Next by Date: Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline
Previous by thread: Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline
Next by thread: Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]