On Wed, Feb 28, 2024 at 03:00:03PM -0800, Raghavendra Rao Ananta wrote: [...] > I sent out a patch in the past to get rid of them [1], but Shaoqin is > currently making an effort to (fix and) use them in their tests [2]. > While we are still reviewing the series, we can apply [1] to unblock > enabling -Werror and Shaqoqin can re-introduce the functions as > needed. But, it's your call. Thanks for the brief, now I remember :) Agreed, let's just delete these upstream. These accessors are simple anyway, and easy to re-review in Shaoqin's tests. Sean -- I'm going to pick up [1] and throw it on the branch with your cleanup. -- Thanks, Oliver
