Hi Shuah, On 2/23/24 23:02, Shuah Khan wrote: > On 2/23/24 14:48, Shuah Khan wrote: >> On 2/22/24 09:29, Laura Nao wrote: >>> Add new basic kselftest that checks if the available rust sample modules >>> can be added and removed correctly. >>> >>> Signed-off-by: Laura Nao <laura.nao@xxxxxxxxxxxxx> >>> Reviewed-by: Sergio Gonzalez Collado <sergio.collado@xxxxxxxxx> >>> Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx> >>> --- >>> Changes in v3: >>> - Removed useless KSFT_PASS, KSFT_FAIL, KSFT_SKIP constants >>> - Used ktap_finished to print the results summary and handle the >>> return code >>> Changes in v2: >>> - Added missing SPDX line >>> - Edited test_probe_samples.sh script to use the common KTAP helpers >>> file >>> --- >>> MAINTAINERS | 1 + >>> tools/testing/selftests/Makefile | 1 + >>> tools/testing/selftests/rust/Makefile | 4 +++ >>> .../selftests/rust/test_probe_samples.sh | 34 +++++++++++++++++++ >>> 4 files changed, 40 insertions(+) >>> create mode 100644 tools/testing/selftests/rust/Makefile >>> create mode 100755 tools/testing/selftests/rust/test_probe_samples.sh >>> >> >> Looks good to me. Don't you need a config file for this test? >> Refer to config files for existing tests as a reference. >> Right, in order for the tests to not be skipped support for rust and its sample modules need to be enabled. I added the config file in v4: https://lore.kernel.org/linux-kselftest/20240226101646.291337-1-laura.nao@xxxxxxxxxxxxx/T/#u > make kselftest TARGETS=rust > or > make run_tests > > On Linux 6.8-rc5 give the following? Doesn't look right. > > TAP version 13 > 1..1 > # timeout set to 45 > # selftests: rust: test_probe_samples.sh > # ./test_probe_samples.sh: line 12: > /linux/linux_6.8/tools/testing/selftests/rust/../kselftest/ktap_helpers.sh: No such file or directory > # ./test_probe_samples.sh: line 16: ktap_print_header: command not found > # ./test_probe_samples.sh: line 18: ktap_set_plan: command not found > # ./test_probe_samples.sh: line 22: ktap_test_skip: command not found > # ./test_probe_samples.sh: line 22: ktap_test_skip: command not found > # ./test_probe_samples.sh: line 34: ktap_finished: command not found > not ok 1 selftests: rust: test_probe_samples.sh # exit=127 > This patch requires https://lore.kernel.org/all/20240102141528.169947-1-laura.nao@xxxxxxxxxxxxx/T/#u and https://lore.kernel.org/all/20240131-ktap-sh-helpers-extend-v1-0-98ffb468712c@xxxxxxxxxxxxx/ , which are both scheduled for 6.9-rc1. Sorry I didn't mention it above! Thanks, Laura
