Re: [PATCH v3] kselftest: Add basic test for probing the rust sample modules

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2/22/24 09:29, Laura Nao wrote:
Add new basic kselftest that checks if the available rust sample modules
can be added and removed correctly.

Signed-off-by: Laura Nao <laura.nao@xxxxxxxxxxxxx>
Reviewed-by: Sergio Gonzalez Collado <sergio.collado@xxxxxxxxx>
Reviewed-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
---
Changes in v3:
- Removed useless KSFT_PASS, KSFT_FAIL, KSFT_SKIP constants
- Used ktap_finished to print the results summary and handle the return code
Changes in v2:
- Added missing SPDX line
- Edited test_probe_samples.sh script to use the common KTAP helpers file
---
  MAINTAINERS                                   |  1 +
  tools/testing/selftests/Makefile              |  1 +
  tools/testing/selftests/rust/Makefile         |  4 +++
  .../selftests/rust/test_probe_samples.sh      | 34 +++++++++++++++++++
  4 files changed, 40 insertions(+)
  create mode 100644 tools/testing/selftests/rust/Makefile
  create mode 100755 tools/testing/selftests/rust/test_probe_samples.sh


Looks good to me. Don't you need a config file for this test?
Refer to config files for existing tests as a reference.

thanks,
-- Shuah




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux