Re: [PATCH net] selftests: cmsg_ipv6: repeat the exact packet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Feb 04, 2024 at 08:56:18AM -0800, Jakub Kicinski wrote:
> cmsg_ipv6 test requests tcpdump to capture 4 packets,
> and sends until tcpdump quits. Only the first packet
> is "real", however, and the rest are basic UDP packets.
> So if tcpdump doesn't start in time it will miss
> the real packet and only capture the UDP ones.
> 
> This makes the test fail on slow machine (no KVM or with
> debug enabled) 100% of the time, while it passes in fast
> environments.
> 
> Repeat the "real" / expected packet.
> 
> Fixes: 9657ad09e1fa ("selftests: net: test IPV6_TCLASS")
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>

I'm not sure if it is important, but doesn't this also:

Fixes: 05ae83d5a4a2 ("selftests: net: test IPV6_HOPLIMIT")

In any case, this looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux