On Tue, Jan 30, 2024 at 10:37:15AM -0800, Nhat Pham wrote: > On Mon, Jan 29, 2024 at 5:02 PM Yosry Ahmed <yosryahmed@xxxxxxxxxx> wrote: > > > > On Mon, Jan 29, 2024 at 02:45:40PM -0800, Nhat Pham wrote: > > > Make it easier for contributors to find the zswap maintainers when they > > > update the zswap tests. > > > > > > Signed-off-by: Nhat Pham <nphamcs@xxxxxxxxx> > > > > I guess I had to check the zswap tests at some point :) > > We sorely need more zswap tests :) > > I'm one of the offenders of adding new features without including > tests, so no judging anyone of course, and admittedly zswap is quite > intertwined with other parts of MM, so it's kinda hard to write > unit-ish tests for zswap only. I often had to resort to scripting > stress tests to iron out bugs. > > But there are still tests that we can write to verify public API > (cgroup's zswap options come to mind), simple tests that cover crucial > code paths, etc. that we should probably add in. At the very least > this can be a quick/sanity check for developing and backporting > patches into the production system. Agreed. I am yet to take a close look at the existing tests tbh, but I took a quick look before and there is room for improvement (and little bandwidth to act on it).
