On Fri, 2024-01-26 at 11:18 -0500, Aaron Conole wrote:
> Paolo Abeni <pabeni@xxxxxxxxxx> writes:
>
> > The big_tcp test-case requires a few kernel knobs currently
> > not specified in the net selftests config, causing the
> > following failure:
> >
> > # selftests: net: big_tcp.sh
> > # Error: Failed to load TC action module.
> > # We have an error talking to the kernel
> > ...
> > # Testing for BIG TCP:
> > # CLI GSO | GW GRO | GW GSO | SER GRO
> > # ./big_tcp.sh: line 107: test: !=: unary operator expected
> > ...
> > # on on on on : [FAIL_on_link1]
> >
> > Add the missing configs
> >
> > Fixes: 6bb382bcf742 ("selftests: add a selftest for big tcp")
> > Signed-off-by: Paolo Abeni <pabeni@xxxxxxxxxx>
> > ---
>
> Thanks for the fix.
>
> Maybe we should also add the config for NET_ACT_CT since we will
> invoke it on setup. I guess there's some dependency that must be
> pulling it in for us already so we don't explicitly call for it, but we
> do require it in setup() if I understand correctly.
This patch already adds NET_ACT_CT=m:
> @@ -71,6 +74,7 @@ CONFIG_NET_CLS_FLOWER=m
> CONFIG_NET_CLS_BPF=m
> CONFIG_NET_ACT_TUNNEL_KEY=m
> CONFIG_NET_ACT_MIRRED=m
> +CONFIG_NET_ACT_CT=m
> CONFIG_BAREUDP=m
> CONFIG_IPV6_IOAM6_LWTUNNEL=y
> CONFIG_CRYPTO_SM4_GENERIC=y
Cheers,
Paolo
