Re: pull-request: wireless-2024-01-22

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 24 Jan 2024 at 02:22, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote:
>
> On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote:
> >
> > We're also adding unit tests to iwlwifi (slowly), any idea if we should
> > enable that here also? It _is_ now possible to build PCI stuff on kunit,
> > but it requires some additional config options (virt-pci etc.), not sure
> > that's desirable here? It doesn't need it at runtime for the tests, of
> > course.
> >
>
> Heh, in fact Miri just posted the first bits:
>
> https://lore.kernel.org/r/20240123200528.a4a8af7c091f.I0fb09083317b331168b99b8db39656a126a5cc4d@changeid
>
>
> Also, should enabling that in
> tools/testing/kunit/configs/all_tests.config go through our tree, or
> better through the kselftest tree?
>

I'd definitely like the iwlwifi tests to be enabled in all_tests.config.

The virt-pci options _should_ already be enabled for the UML configs
under kunit.py by default now (they're in
.../configs/arch_uml.config).

I don't mind which tree the changes to all_tests.config go through --
I suspect it's probably better for them to go in via your tree,
particularly if they end up depending on any new config options.

-- David

Attachment: smime.p7s
Description: S/MIME Cryptographic Signature


[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux