Re: [PATCH net] selftests: tcp_ao: set the timeout to 2 minutes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/24/24 23:36, Jakub Kicinski wrote:
> The default timeout for tests is 45sec, bench-lookups_ipv6
> seems to take around 50sec when running in a VM without
> HW acceleration. Give it a 2x margin and set the timeout
> to 120sec.
> 
> Fixes: d1066c9c58d4 ("selftests/net: Add test/benchmark for removing MKTs")
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>

Thanks!
Reviewed-by: Dmitry Safonov <0x7f454c46@xxxxxxxxx>

> ---
> Long story short I looked at the output for bench-lookups_ipv6
> and it seems to be a trivial timeout problem. With this we're at
> 22/24 passing for TCP AO, the reset case failures aren't as obvious...

I'll fix and send a patch for rst selftests on Thursday/Friday :)

> CC: shuah@xxxxxxxxxx
> CC: 0x7f454c46@xxxxxxxxx
> CC: linux-kselftest@xxxxxxxxxxxxxxx
> ---
>  tools/testing/selftests/net/tcp_ao/settings | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 tools/testing/selftests/net/tcp_ao/settings
> 
> diff --git a/tools/testing/selftests/net/tcp_ao/settings b/tools/testing/selftests/net/tcp_ao/settings
> new file mode 100644
> index 000000000000..6091b45d226b
> --- /dev/null
> +++ b/tools/testing/selftests/net/tcp_ao/settings
> @@ -0,0 +1 @@
> +timeout=120

Thanks,
             Dmitry





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux