On 1/22/24 14:08, Mark Brown wrote:
The seccomp benchmark test makes a number of checks on the performance it measures and logs them to the output but does so in a custom format which none of the automated test runners understand meaning that the chances that anyone is paying attention are slim. Let's additionally log each result in KTAP format so that automated systems parsing the test output will see each comparison as a test case. The original logs are left in place since they provide the actual numbers for analysis. As part of this rework the flow for the main program so that when we skip tests we still log all the tests we skip, this is because the standard KTAP headers and footers include counts of the number of expected and run tests. Tested-by: Anders Roxell <anders.roxell@xxxxxxxxxx> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> ---
- return 0; + if (ret) { + ksft_print_msg("Saw unexpected benchmark result. Try running again with more samples?\n"); + } +
WARNING: braces {} are not necessary for single statement blocks
+ ksft_finished(); }
Mark, Can you fix this warning. Tried fixing it --fix-inplace and no luck. thanks, -- Shuah