On Mon, 2024-01-22 at 17:05 +0800, Hangbin Liu wrote: > The busywait timeout value is a millisecond, not a second. So the > current setting 2 is meaningless. Let's copy the WAIT_TIMEOUT from > forwarding/lib.sh and set a BUSYWAIT_TIMEOUT here. > > Signed-off-by: Hangbin Liu <liuhangbin@xxxxxxxxx> > --- > Not sure if the default WAIT_TIMEOUT 20s is too large. But since > we usually don't need to wait for that long. I think it's OK to > stay the same value with forwarding/lib.sh. Please tell me if you > think we need to set a more proper value. > > BTW, This doesn't look like a fix. But also not a feature. So I just > post it to net tree. I think the 20s max timeout is fine. I also think this is really a fix: on slow/busy host (or VMs) the current timeout can expire even on "correct" execution, causing random failures. We had a lot of similar case in the mptcp self-tests in the past. Could you please send a v2 with a suitable fixes tag and an update changelog to point out the possible failures? Thanks! Paolo
