On Mon, 2024-01-22 at 22:05 -0800, Jakub Kicinski wrote:
> This test is missing a whole bunch of checks for interface
> renaming and one ifup. Presumably it was only used on a system
> with renaming disabled and NetworkManager running.
>
> Fixes: 91f430b2c49d ("selftests: net: add a test for UDP tunnel info infra")
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> CC: shuah@xxxxxxxxxx
> CC: horms@xxxxxxxxxx
> CC: linux-kselftest@xxxxxxxxxxxxxxx
> ---
> .../selftests/drivers/net/netdevsim/udp_tunnel_nic.sh | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh b/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> index 4855ef597a15..f98435c502f6 100755
> --- a/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> +++ b/tools/testing/selftests/drivers/net/netdevsim/udp_tunnel_nic.sh
> @@ -270,6 +270,7 @@ for port in 0 1; do
> echo 1 > $NSIM_DEV_SYS/new_port
> fi
> NSIM_NETDEV=`get_netdev_name old_netdevs`
> + ifconfig $NSIM_NETDEV up
WoW! I initially thought the above was a typo, before noticing it's
actually consistent with the whole script :)
Do you think we should look at dropping ifconfig usage from self-tests?
I guess that in the long run most systems should not have such command
available in the default install.
In any case the patch LGTM.
Acked-by: Paolo Abeni <pabeni@xxxxxxxxxx>
Cheers,
Paolo
