On Wed, Jan 17, 2024 at 07:12:32PM -0500, Benjamin Poirier wrote:
> When tests are run by runner.sh, bond_options.sh gets killed before
> it can complete:
>
> make -C tools/testing/selftests run_tests TARGETS="drivers/net/bonding"
> [...]
> # timeout set to 120
> # selftests: drivers/net/bonding: bond_options.sh
> # TEST: prio (active-backup miimon primary_reselect 0) [ OK ]
> # TEST: prio (active-backup miimon primary_reselect 1) [ OK ]
> # TEST: prio (active-backup miimon primary_reselect 2) [ OK ]
> # TEST: prio (active-backup arp_ip_target primary_reselect 0) [ OK ]
> # TEST: prio (active-backup arp_ip_target primary_reselect 1) [ OK ]
> # TEST: prio (active-backup arp_ip_target primary_reselect 2) [ OK ]
> #
> not ok 7 selftests: drivers/net/bonding: bond_options.sh # TIMEOUT 120 seconds
>
> This test includes many sleep statements, at least some of which are
> related to timers in the operation of the bonding driver itself. Increase
> the test timeout to allow the test to complete.
>
> I ran the test in slightly different VMs (including one without HW
> virtualization support) and got runtimes of 13m39.760s, 13m31.238s, and
> 13m2.956s. Use a ~1.5x "safety factor" and set the timeout to 1200s.
>
> Fixes: 42a8d4aaea84 ("selftests: bonding: add bonding prio option test")
> Reported-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Closes: https://lore.kernel.org/netdev/20240116104402.1203850a@xxxxxxxxxx/#t
> Suggested-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Benjamin Poirier <bpoirier@xxxxxxxxxx>
> ---
> tools/testing/selftests/drivers/net/bonding/settings | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/drivers/net/bonding/settings b/tools/testing/selftests/drivers/net/bonding/settings
> index 6091b45d226b..79b65bdf05db 100644
> --- a/tools/testing/selftests/drivers/net/bonding/settings
> +++ b/tools/testing/selftests/drivers/net/bonding/settings
> @@ -1 +1 @@
> -timeout=120
> +timeout=1200
> --
> 2.43.0
>
Thanks, I will check how to use busywait in bonding test.
Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxx>
