On Fri, Jan 12, 2024 at 08:21:29AM +0800, Yan Zhao wrote: > On Wed, Jan 10, 2024 at 02:27:08PM +0800, Yuan Yao wrote: > > > > Do you have plan to allow user to change the bar_size via IOCTL ? > > > > If no "order" and "bar_size" can be removed. > > > > > > > Currently no. But this structure is private to the test driver. > > > What the benefit to remove the two? > > > > It's useless so remove them makes code more easier to understand. > Just my two cents: > Keeping bar_size & order in a device structure is better than spreading > macro BAR_SIZE everywhere and the code is more scalable. yeah, that depends on the perspective, no big deal to me. You can wait other's input.
