On Tue, Dec 26, 2023 at 08:51:43PM +0800, Hangbin Liu wrote: > On Tue, Dec 26, 2023 at 04:43:18PM +0800, Yujie Liu wrote: > > Hi Hangbin, > > > > On Mon, Dec 25, 2023 at 08:39:09PM +0800, Hangbin Liu wrote: > > > On Mon, Dec 25, 2023 at 03:21:09PM +0800, Yujie Liu wrote: > > > > The patch set [1] added a general lib.sh in net selftests, and converted > > > > several test scripts to source the lib.sh. > > > > > > Oh, I didn't know dash doesn't support "source". Thanks for the fix. > > > Would you please also help fix the pmtu.sh, which has the same issue? > > > > It looks like pmtu.sh was not converted in patch set [1], so it doesn't > > have "source lib.sh" yet. The cover letter of [1] mentions that the > > whole process of conversion will be split into several parts. Not sure > > if pmtu.sh will be converted in the subsequent parts soon? If so, would > > you like to change the shebang of pmtu.sh when converting it later, or > > change it together in this patch? Thanks. > > The pmtu.sh update is in this patch set. > https://lore.kernel.org/all/20231219094856.1740079-1-liuhangbin@xxxxxxxxx/ > > It would be good to fix these 2 tests together. Sorry for the late reply due to recent holiday. v2 patch has been sent at: https://lore.kernel.org/all/20231229131931.3961150-1-yujie.liu@xxxxxxxxx/ Please kindly review. Thanks, Yujie > > > > BTW, in addition to pmtu.sh, I noticed that there are several other > > scripts in net selftests which have "/bin/sh" shebang: > > Yes, but the other tests don't use "source". > > > > > linux/tools/testing/selftests/net$ grep -rF '#!/bin/sh' > > openvswitch/openvswitch.sh:#!/bin/sh > > in_netns.sh:#!/bin/sh > > netdevice.sh:#!/bin/sh > > test_bpf.sh:#!/bin/sh > > test_blackhole_dev.sh:#!/bin/sh > > vlan_hw_filter.sh:#!/bin/sh > > run_netsocktests:#!/bin/sh > > pmtu.sh:#!/bin/sh > > bareudp.sh:#!/bin/sh > > l2_tos_ttl_inherit.sh:#!/bin/sh > > veth.sh:#!/bin/sh > > ipv6_flowlabel.sh:#!/bin/sh > > unicast_extensions.sh:#!/bin/sh > > reuseport_addr_any.sh:#!/bin/sh > > run_afpackettests:#!/bin/sh > > ip_local_port_range.sh:#!/bin/sh > > amt.sh:#!/bin/sh > > udpgso.sh:#!/bin/sh > > ip_defrag.sh:#!/bin/sh > > rps_default_mask.sh:#!/bin/sh > > > > > BTW, you can change the "source ./lib.sh" to "source lib.sh" to consistent > > > with other tests. > > > > Sure, will respin a v2 with this change added. > > Thanks > Hangbin
