On 2023/12/22 12:23, Tian, Kevin wrote:
From: Liu, Yi L <yi.l.liu@xxxxxxxxx> Sent: Thursday, December 21, 2023 11:40 PM + fault &= DMA_FSTS_IQE | DMA_FSTS_ITE | DMA_FSTS_ICE; + if (fault) { + if (fsts) + *fsts |= fault;do we expect the fault to be accumulated? otherwise it's clearer to just do direct assignment instead of asking for the caller to clear the variable before invocation.
not quite get. do you mean the fault should not be cleared in the caller side?
the rest looks good: Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>
-- Regards, Yi Liu
