On Tue, Dec 19, 2023 at 5:50 AM Menglong Dong <menglong8.dong@xxxxxxxxx> wrote: > > The "S32_MIN" is already defined with s32 casting, so there is no need > to do it again. > > Signed-off-by: Menglong Dong <menglong8.dong@xxxxxxxxx> > --- > tools/testing/selftests/bpf/prog_tests/reg_bounds.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Acked-by: Andrii Nakryiko <andrii@xxxxxxxxxx> > diff --git a/tools/testing/selftests/bpf/prog_tests/reg_bounds.c b/tools/testing/selftests/bpf/prog_tests/reg_bounds.c > index 0c9abd279e18..3bf4ddd720a8 100644 > --- a/tools/testing/selftests/bpf/prog_tests/reg_bounds.c > +++ b/tools/testing/selftests/bpf/prog_tests/reg_bounds.c > @@ -2097,10 +2097,10 @@ static struct subtest_case crafted_cases[] = { > > {U32, S32, {0, U32_MAX}, {U32_MAX, U32_MAX}}, > > - {S32, U64, {(u32)(s32)S32_MIN, (u32)(s32)S32_MIN}, {(u32)(s32)-255, 0}}, > - {S32, S64, {(u32)(s32)S32_MIN, (u32)(s32)-255}, {(u32)(s32)-2, 0}}, > - {S32, S64, {0, 1}, {(u32)(s32)S32_MIN, (u32)(s32)S32_MIN}}, > - {S32, U32, {(u32)(s32)S32_MIN, (u32)(s32)S32_MIN}, {(u32)(s32)S32_MIN, (u32)(s32)S32_MIN}}, > + {S32, U64, {(u32)S32_MIN, (u32)S32_MIN}, {(u32)(s32)-255, 0}}, > + {S32, S64, {(u32)S32_MIN, (u32)(s32)-255}, {(u32)(s32)-2, 0}}, > + {S32, S64, {0, 1}, {(u32)S32_MIN, (u32)S32_MIN}}, > + {S32, U32, {(u32)S32_MIN, (u32)S32_MIN}, {(u32)S32_MIN, (u32)S32_MIN}}, > }; > > /* Go over crafted hard-coded cases. This is fast, so we do it as part of > -- > 2.39.2 >