Hi Ilpo, On 12/15/2023 7:04 AM, Ilpo Järvinen wrote: > Callers of get_cbm_mask() are required to pass a string into which the > capacity bitmask (CBM) is read. Neither CAT nor CMT tests need the > bitmask as string but just convert it into an unsigned long value. > > Another limitation is that the bit mask reader can only read > .../cbm_mask files. > > Generalize the bit mask reading function into get_bit_mask() such that > it can be used to handle other files besides the .../cbm_mask and > handles the unsigned long conversion within get_bit_mask() using > fscanf(). Change get_cbm_mask() to use get_bit_mask() and rename it to > get_full_cbm() to better indicate what the function does. > > Return error from get_full_cbm() if the bitmask is zero for some reason > because it makes the code more robust as the selftests naturally assume > the bitmask has some bits. > > Also mark cache_type const while at it and remove useless comments that > are related to processing of CBM bits. > > Co-developed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx> > --- Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx> Reinette
