On Wed, 13 Dec 2023 at 23:04, Maxime Ripard <mripard@xxxxxxxxxx> wrote: > > Hi David, > > On Fri, Dec 08, 2023 at 06:09:28PM +0800, davidgow@xxxxxxxxxx wrote: > > KUnit tests often need to provide a struct device, and thus far have > > mostly been using root_device_register() or platform devices to create > > a 'fake device' for use with, e.g., code which uses device-managed > > resources. This has several disadvantages, including not being designed > > for test use, scattering files in sysfs, and requiring manual teardown > > on test exit, which may not always be possible in case of failure. > > > > Instead, introduce a set of helper functions which allow devices > > (internally a struct kunit_device) to be created and managed by KUnit -- > > i.e., they will be automatically unregistered on test exit. These > > helpers can either use a user-provided struct device_driver, or have one > > automatically created and managed by KUnit. In both cases, the device > > lives on a new kunit_bus. > > > > This is a follow-up to a previous proposal here: > > https://lore.kernel.org/linux-kselftest/20230325043104.3761770-1-davidgow@xxxxxxxxxx/ > > > > (The kunit_defer() function in the first patch there has since been > > merged as the 'deferred actions' feature.) > > > > My intention is to take this whole series in via the kselftest/kunit > > branch, but I'm equally okay with splitting up the later patches which > > use this to go via the various subsystem trees in case there are merge > > conflicts. > > Could you take (and apply eventually) that patch as part of your series? > https://lore.kernel.org/linux-kselftest/20231205090405.153140-1-mripard@xxxxxxxxxx/ > Thanks -- I've included it in v3 (which fixes a few other issues), and will take it along with the rest of the series: https://lore.kernel.org/linux-kselftest/20231214-kunit_bus-v3-0-7e9a287d3048@xxxxxxxxxx/T/ Cheers, -- David
Attachment:
smime.p7s
Description: S/MIME Cryptographic Signature
